Allow instrumenting external functions #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvingo
reviewed
Feb 4, 2023
dvingo
reviewed
Feb 4, 2023
|
Looks good and a change most welcome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a currently broken attempt at fixing #840. I don't know enough about cljs to know how to solve it, but for clj it works well enough.I should note that in clj, it doesn't work for any function that is "inlined". So, if you say
(m/=> clojure.core/inc [:=> [:cat :int] :int]), calling(inc "1")won't be instrumented as it's compiled to a rawNumbers.inc("1")call. However, writing(#'inc "1")will be instrumented as it will be compiled intoconst__0.invoke("i").I think that if this is noted in the docs it's an acceptable trade-off.
Closes #840