Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on bb master which adds compatibility with malli. Fixes #302.
Notes:
:bb
reader conditionals rely less on internal details of Clojure and use core functions instead, similar to what happens in:cljs
branches. As discussed with @puredanger, I didn't addLazilyPersistentVector
to bb as that was too far off from what is considered a public API.borkdude/dynaload
which was made compatible with bbload-string
in bb, since SCI itself isn't exposed yet (might happen in the future). SCI also haseval-form
which lets you skip the string parsing bit, that might be more performant, but we can address that in a future PR.@ikitommi I'm not sure what the workflow is with
metosin/malli
but I usually squash+merge the commits through the Github option (dropdown in merge button). If you want I can squash this PR manually as well.If you want to try:
for installing bb master in /tmp.
Then in a script: