Add new utility functions: m/explain-data, m/data-explainer, mu/keys #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opqdonut
commented
May 23, 2022
opqdonut
commented
May 23, 2022
opqdonut
commented
May 23, 2022
The output of m/explainer, m/explain isn't serializable as-is. You get an error like InvalidDefinitionException: No serializer found for class malli.core$_map_schema$reify$reify__9118 Provide alternatives m/data-explainer and m/explain-data which walk over the result and transform schemas to data using m/form.
ikitommi
requested changes
May 23, 2022
the :schema keys are in known places, opt for direct update
plus add a test
|
I didn't rebase/squash anything to make reviewing easier. I can squash this into two nice commits if you want. |
ikitommi
approved these changes
May 24, 2022
ikitommi
reviewed
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue I'm trying to fix here is not being able to serialize the output of m/explain. See commit message for more.
mu/keys was just something simple I've been missing so I'm adding it in the same PR :)