Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schematize children once in -applying (instead of 3x) #1178

Merged
merged 3 commits into from
Mar 21, 2025
Merged

schematize children once in -applying (instead of 3x) #1178

merged 3 commits into from
Mar 21, 2025

Conversation

frenchy64
Copy link
Collaborator

@frenchy64 frenchy64 commented Mar 19, 2025 •
edited
Loading

I also noticed we can skip the call to apply for the one schema we use -applying for.

@frenchy64 frenchy64 changed the title WIP: schematize children once in -applying (instead of 3x) schematize children once in -applying (instead of 3x) Mar 19, 2025
@frenchy64 frenchy64 marked this pull request as ready for review March 19, 2025 23:48
@frenchy64 frenchy64 requested review from opqdonut and ikitommi March 19, 2025 23:48
@opqdonut
Copy link
Member

thanks, understanding what -applying is for took a while, but now I'm richer for the experience 😉

@frenchy64 frenchy64 merged commit 3c02f9c into metosin:master Mar 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opqdonut opqdonut opqdonut approved these changes

@ikitommi ikitommi ikitommi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frenchy64 @opqdonut @ikitommi