Restore clojure 1.11 CI jobs, add JDK 23 #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchy64
changed the title
|
Our README says
so either we should bump that to 12, or to reinstate the clojure-11 alias to keep testing with it. Previously, we were claiming to support clojure 1.10, but since the CI config was broken, clojure 1.11-specific code had crept in, which was a bit embarrassing. |
|
Ah good catch. I will attempt to add back the Clojure 1.11 jobs to see if they still work. Then the decision can be made on its own merits. |
frenchy64
changed the title
frenchy64
changed the title
frenchy64
changed the title
|
seems to work, and I'm happy the tests still pass on clj 11 |
opqdonut
approved these changes
Mar 14, 2025
|
Whoops, I never added JDK 23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1174
Clojure 1.11 jobs are redundant after removing the
:clojure-11alias.