MOBT-680: Update cycle time related coords when enforcing cube consistency #2096
Conversation
… in the wind gust chain when the update is prompted by a wind speed update and consistency is enforced on older data.
…the reference cube being used to update the same on the enforced cube.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 98.39% 98.41% +0.02%
==========================================
Files 124 135 +11
Lines 12212 13324 +1112
==========================================
+ Hits 12016 13113 +1097
- Misses 196 211 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks @bayliffe 👍
I think that this is fine. I've added some very minor comments and a query regarding what the default behaviour should actually be.
| @@ -17,6 +17,7 @@ def process( | |||
| multiplicative_amount: cli.comma_separated_list_of_float = [1.0], | |||
| comparison_operator: cli.comma_separated_list = [">="], | |||
| diff_for_warning: float = None, | |||
| use_latest_update_time: bool = False, | |||
There was a problem hiding this comment.
Just wondering:
- should this actually be an option for the CLI, or should this just be the default behaviour?
- should this be True by default?
There was a problem hiding this comment.
I didn't like to assume that someone wants this. Making it optional means that we have not changed other processes that use this, e.g. precipitation phases enforced against precipitation.
I don't have a strong view against such a change. Would it be your preference that this defaults to True in the plugin? Would you not even expose the option within the CLI? My default is to leave as is, but if you think otherwise I'll change it.
There was a problem hiding this comment.
I'm happy to leave it as it is. I just wanted to be sure that this had been considered.
This code allows us to optionally adopt a more recent forecast_reference_time or blend_time when enforcing consistency on a forecast cube. The most recent of those available on the cubes involved in the consistency check is used.
This is useful for our wind gust use case where the wind speed may be from a newer cycle and the wind gust from an older cycle. We want to ensure that when we resend the wind gust after the reapplication of consistency with a newer wind speed input we update the forecast reference time and / or blend time.
Testing: