Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include influence of day weighting in the intensity categorisation #2028

Conversation

gavinevans
Copy link
Contributor

Related to https://github.com/metoppv/mo-blue-team/issues/742

Description
Edit to include the influence of day weighting when performing the intensity categorisation.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

Copy link
Contributor

@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour is now as I would expect for the emphasis of daytime symbols. Perhaps this would have shown up more clearly testing in UK winter, as I struggled to find enough precipitation cases, still I'm glad it got caught. Good work Gavin.

@bayliffe bayliffe merged commit 1471c9e into metoppv:1.6.x Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants