Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make difference module handle circular cubes #2016

Merged
merged 28 commits into from
Jul 16, 2024
Merged

Make difference module handle circular cubes #2016

merged 28 commits into from
Jul 16, 2024

Commits on Apr 23, 2024

  1. Resolved merge conflict

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    50d08bb View commit details
    Browse the repository at this point in the history

  2. Added another failing test for difference module. Differences calcula… 

    …ted correctly but need to add extra dimension for the wrap-around distance.
    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e4bce85 View commit details
    Browse the repository at this point in the history

  3. Resolved merge conflicts

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    beabc9e View commit details
    Browse the repository at this point in the history

  4. Auto-formatting

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    141ee1f View commit details
    Browse the repository at this point in the history

  5. Import Bugfix

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9535d45 View commit details
    Browse the repository at this point in the history

  6. Ran isort against spatial.py

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c442023 View commit details
    Browse the repository at this point in the history

  7. Added test for appropriate error for unhandled cubes and made code ma… 

    …tch it.
    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    62dc4d9 View commit details
    Browse the repository at this point in the history

  8. iSort on spatial.py again

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    636ec69 View commit details
    Browse the repository at this point in the history

  9. Another attempt at autoformatting

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fa2b8b0 View commit details
    Browse the repository at this point in the history

  10. Tidied up

    @MO-PeterJordan
    MO-PeterJordan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    53659a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Removed confusing variable name

    @MO-PeterJordan
    MO-PeterJordan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    617bd27 View commit details
    Browse the repository at this point in the history

  2. Autoformatting

    @MO-PeterJordan
    MO-PeterJordan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0910cd6 View commit details
    Browse the repository at this point in the history

  3. Tried manually sorting import order as isort still failing in github … 

    …actions despite running locally and pushing
    @MO-PeterJordan
    MO-PeterJordan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8082dd0 View commit details
    Browse the repository at this point in the history

  4. And again

    @MO-PeterJordan
    MO-PeterJordan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    22e920a View commit details
    Browse the repository at this point in the history

  5. And again

    @MO-PeterJordan
    MO-PeterJordan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ce71d4c View commit details
    Browse the repository at this point in the history

  6. Linting suggestion

    @MO-PeterJordan
    MO-PeterJordan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b74833b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Review Actions

    @MO-PeterJordan
    MO-PeterJordan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ccdc67f View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Ran isort to fix gha

    @MO-PeterJordan
    MO-PeterJordan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c51ad05 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Added test for cubes with flipped axes (lonitude increasing along col… 

    …umns not rows and vice versa for latitude). Fixed code to handle this case.
    @MO-PeterJordan
    MO-PeterJordan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8eb9195 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pjordan-make-difference-module-handle-circ… 

    …ular-cubes
    @MO-PeterJordan
    MO-PeterJordan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    939ac46 View commit details
    Browse the repository at this point in the history

  3. black, isort, flake8

    @MO-PeterJordan
    MO-PeterJordan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e3496eb View commit details
    Browse the repository at this point in the history

  4. Ran isort in isolation

    @MO-PeterJordan
    MO-PeterJordan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    175e825 View commit details
    Browse the repository at this point in the history

  5. Fixed test failures resulting from breaking changes made by upstream PR

    @MO-PeterJordan
    MO-PeterJordan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6fbc3eb View commit details
    Browse the repository at this point in the history

  6. Black

    @MO-PeterJordan
    MO-PeterJordan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    31fceb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'pjordan-make-difference-module-handle-circular-cubes' of … 

    …https://github.com/MO-PeterJordan/improver-peterjordan into circular_difference
    Marcus Spelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    24398ee View commit details
    Browse the repository at this point in the history

  2. updates as per review comments and adds test for 0-360 degree case

    Marcus Spelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7415794 View commit details
    Browse the repository at this point in the history

  3. update comment

    Marcus Spelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e2321dd View commit details
    Browse the repository at this point in the history

  4. formatting

    Marcus Spelman committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    69b5734 View commit details
    Browse the repository at this point in the history