Made set_up_variable_cube test helper support non-square grid cells #1988
Conversation
Done |
MO-PeterJordan
force-pushed
the
make-set-up-variable-cube-support-non-square-cubes
branch
3 times, most recently
from
df6e555
to
7fe71ea
Compare
|
Have rebased to edit original commit author to match correct name in mailmap (i.e. Peter Jordan) |
|
This still isn't happy. It seems that the commit that squashes all your previous commits together is authored by |
…ed contributors list and mailmap Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk> Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk>
MO-PeterJordan
force-pushed
the
make-set-up-variable-cube-support-non-square-cubes
branch
from
7fe71ea
to
730109d
Compare
There was a problem hiding this comment.
While all the automated CI tests pass, these do not include the acceptance tests, and there's one set that fail. They're all associated with this CLI:
improver/cli/generate_metadata_cube.py
The issue is that the cli always passes in a keyword argument {"grid_spacing": None}, except for the one acceptance test that actually sets a value to it. This code needs reworking to get it to pass.
source etc/site-init
export IMPROVER_ACC_TEST_DIR=/data/users/cfst/improver_test_data/data
pytest improver_tests/acceptance/test_generate_metadata_cube.py
|
All tests now pass. Ready for re-review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1988 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 124 124
Lines 12209 12212 +3
=======================================
+ Hits 12013 12016 +3
Misses 196 196 ☔ View full report in Codecov by Sentry. |
improver_tests/blending/calculate_weights_and_blend/test_WeightAndBlend.py
Outdated
Show resolved
Hide resolved
MO-PeterJordan
deleted the
make-set-up-variable-cube-support-non-square-cubes
branch
…etoppv#1988) * Changed helper methods and updated tests using it to match. Also signed contributors list and mailmap Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk> Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk> * Changed one of the generate metadata tests to match new set-up-test-cube logic * Fixed generate_metadata tests * Tidying up * small review acton * Added tests for test cubes with equal x and y dimensions * Bugfix --------- Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk>
Made set_up_variable_cube test helper support non-square grid cells
This supports making gradient divide by distance instead of degrees. Specifically it is required to allow testing of gradient for circular coordinate systems.
Testing:
CLA