Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce percentile consistency #1897

Conversation

gavinevans
Copy link
Contributor

Addresses https://github.com/metoppv/mo-blue-team/issues/492

Description
Add a plugin and CLI for ensuring consistency between two diagnostics in percentile format. This has been created with wind speed and wind gust in mind, where different processing may result in wind speed and wind gust percentiles that are inconsistent i.e. where the wind gust is lower than the wind speed.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

… in percentile format. This has been created with wind speed and wind gust in mind, where different processing may result in wind speed and wind gust percentiles that are non consistent i.e. where the wind gust is lower than the wind speed.
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1897 (d8c160c) into master (4d7b96f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1897   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files         119      120    +1     
  Lines       11312    11327   +15     
=======================================
+ Hits        11122    11137   +15     
  Misses        190      190           
Impacted Files Coverage Δ
improver/utilities/enforce_consistency.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brhooper brhooper self-assigned this Apr 27, 2023
@gavinevans
Copy link
Contributor Author

Closed in favour of attempting to create a more general utility for enforcing consistency.

@gavinevans gavinevans closed this Apr 27, 2023
@brhooper brhooper removed their assignment Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants