EEA reader #44
EEA reader #44
Conversation
…Data from data; have not tested that the rest of the reading works
|
Still to be done:
|
There was a problem hiding this comment.
Thanks for the implementation. Please use std-python libs or existing dependencies unless really required and discussed elsewhere.
I think metadata should be part of the data-download, not part of this reader. See the existing database at: /lustre/storeB/project/aerocom/aerocom1/AEROCOM_OBSDATA/EEA_AQeRep.v2/download
The test-database is much too big. Please shrink it to ~100k in total. Some files have more than 1MB.
| with open("concentration.csv") as source: | ||
| response = [] | ||
| for line in source: | ||
| words = line.split(",") |
There was a problem hiding this comment.
consider using csv module with DictReader. Much easier to read line["Sampling Point Id"] than words[0].
separator seems to be ", "
|
PR metno/pyaerocom#1335 must also be merge before the reader works with aeroval |
| from pathlib import Path | ||
|
|
||
|
|
||
| import tomli as tomllib |
There was a problem hiding this comment.
this should have a version test since tomllib is include >= python 3.11
| if sys.version_info.minor >= 11: | ||
| import tomllib | ||
| else: | ||
| import tomli as tomllib |
There was a problem hiding this comment.
if sys.version_info >= (3, 11):
import tomllib
else:
import tomli as tomllib
or more pragmatic:
try:
import tomllib
except ImportError:
import tomli as tomllib
No description provided.