Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the diurnal cycle evaluation working again #859

Closed
wants to merge 68 commits into from

Conversation

jgriesfeller
Copy link
Member

This PR will make the diurnal cycle analysis work again. WIP at the moment

dulte and others added 30 commits August 10, 2022 11:58
# Conflicts:
#	pyaerocom/aeroval/glob_defaults.py
# Conflicts:
#	pyaerocom/aeroval/glob_defaults.py
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 26.00% and project coverage change: +78.31 🎉

Comparison is base (f0a33c5) 0.00% compared to head (5c71176) 78.31%.

Additional details and impacted files
@@              Coverage Diff              @@
##           main-dev     #859       +/-   ##
=============================================
+ Coverage      0.00%   78.31%   +78.31%     
=============================================
  Files           102      106        +4     
  Lines         17597    18092      +495     
=============================================
+ Hits              0    14168    +14168     
+ Misses        17597     3924    -13673     
Flag Coverage Δ
unittests 78.31% <26.00%> (+78.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/_concprcp_units_helpers.py 100.00% <ø> (+100.00%) ⬆️
pyaerocom/aeroval/helpers.py 89.41% <ø> (+89.41%) ⬆️
pyaerocom/aeroval/modelmaps_engine.py 77.65% <ø> (+77.65%) ⬆️
pyaerocom/aeroval/modelmaps_helpers.py 85.33% <ø> (+85.33%) ⬆️
pyaerocom/aeroval/superobs_engine.py 85.71% <ø> (+85.71%) ⬆️
pyaerocom/combine_vardata_ungridded.py 82.16% <ø> (+82.16%) ⬆️
pyaerocom/griddeddata.py 71.76% <0.00%> (+71.76%) ⬆️
pyaerocom/helpers.py 77.67% <ø> (+77.67%) ⬆️
pyaerocom/io/aerocom_browser.py 78.16% <ø> (+78.16%) ⬆️
pyaerocom/io/cachehandler_ungridded.py 78.52% <ø> (+78.52%) ⬆️
... and 40 more

... and 56 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jgriesfeller
Copy link
Member Author

closing pull request since it has been solved at the aeroval / Java Script level by @AugustinMortier

@jgriesfeller jgriesfeller deleted the griesie_diurnal branch September 25, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants