Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract periods from date range, add new models #685

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

charlienegri
Copy link
Collaborator

note on edge cases where start/end dates are the end/beginning of a year:

with make_period(datetime(2018,12,31),datetime(2022,1,1)) this gives
['20181231-20220101', '20181231-20181231', '20190101-20191231', '20200101-20201231', '20210101-20211231', '20220101-20220101']
I assume this is the intended behavior, but if not we can change the function

@avaldebe
Copy link
Collaborator

@charlienegri the lint, docs and venv jobs are crashing because Cartopy packages are incompatible with the new dependency resolver used by pip. See #686 for details.

After that PR is merged, merging main-dev into this branch should fix some of the CI jobs.
However, I do not know why the conda jobs are failing.

@charlienegri
Copy link
Collaborator Author

I have no clue, a lot of tests are failing but I don't think this branch ever passed the pipeline

@avaldebe
Copy link
Collaborator

I have no clue, a lot of tests are failing but I don't think this branch ever passed the pipeline

mmmm, maybe we should have a bot that closes PRs if they fail all tests, delete the branch and kick the PR author from the project. Or maybe it is time to "go home" and have diner... 💩

add MINNI and MONARCH and arrange alphabetically except for ENSEMBLE
@charlienegri charlienegri changed the title extract periods from date range extract periods from date range, add new models Jun 24, 2022
@charlienegri
Copy link
Collaborator Author

the tests are failing because of the different way of handling the dates as datetime objects and because of the new definition of periods, I can look into this more and try to fix them

@dulte
Copy link
Collaborator

dulte commented Jun 28, 2022

Looks good. will fix failing tests in the other branch

@charlienegri charlienegri merged commit ffa606f into fix-missing-dates-cams2-83 Jun 28, 2022
@charlienegri charlienegri deleted the charlienegri-patch-1 branch June 28, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants