extract periods from date range, add new models #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note on edge cases where start/end dates are the end/beginning of a year:
with
make_period(datetime(2018,12,31),datetime(2022,1,1))
this gives['20181231-20220101', '20181231-20181231', '20190101-20191231', '20200101-20201231', '20210101-20211231', '20220101-20220101']
I assume this is the intended behavior, but if not we can change the function