Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if var_order_menu does not match used variables #1466

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Dec 19, 2024

Change Summary

Logs a warning with the variables that are missing from var_order_menu when validating EvalSetup.

Related issue number

closes #1453

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2025-01 milestone Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (82a50eb) to head (310e0ff).
Report is 7 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1466      +/-   ##
============================================
+ Coverage     78.49%   78.50%   +0.01%     
============================================
  Files           139      139              
  Lines         21090    21101      +11     
============================================
+ Hits          16554    16565      +11     
  Misses         4536     4536              
Flag Coverage Δ
unittests 78.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review January 6, 2025 08:26
@thorbjoernl thorbjoernl requested a review from lewisblake January 6, 2025 08:26
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lewisblake lewisblake merged commit 229b055 into main-dev Jan 6, 2025
8 checks passed
@lewisblake lewisblake deleted the warning-var-order-menu branch January 6, 2025 10:24
@thorbjoernl thorbjoernl restored the warning-var-order-menu branch January 6, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintuitive behaviour of var_order_menu
2 participants