Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ColocatedData.to_dataframe() method #1369

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Oct 8, 2024

Change Summary

I found the current implementation of ColocatedData.to_dataframe() lacking so I expanded it a bit.

Produced data frames will now include:

  • Time
  • Station name
  • Data source (obs/mod)
  • Latitude
  • Longitude
  • Altitude
  • Variable value (obs/mod)

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (f0acbf6) to head (23809dc).
Report is 38 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/colocation/colocated_data.py 75.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1369      +/-   ##
============================================
+ Coverage     78.85%   78.87%   +0.01%     
============================================
  Files           136      136              
  Lines         20849    20863      +14     
============================================
+ Hits          16441    16455      +14     
  Misses         4408     4408              
Flag Coverage Δ
unittests 78.87% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review October 9, 2024 08:37
@thorbjoernl thorbjoernl added this to the m2024-10 milestone Oct 9, 2024
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💮

@lewisblake lewisblake merged commit 661b82f into main-dev Oct 10, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the expand-colocated-data-to_dataframe branch October 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants