Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsentry.py to remove deprecated allow_mutation=False #1367

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Oct 8, 2024

Tried setting frozen=True but this breaks 25 tests in tests/aeroval and tests/cams2_83, so for now we keep it mutable

Change Summary

Title

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Tried setting frozen=True but this breaks 25 tests in tests/aeroval and tests/cams2_83, so for now we keep it mutable
@lewisblake lewisblake added this to the m2024-10 milestone Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (114ecdd) to head (665a27c).
Report is 18 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1367   +/-   ##
=========================================
  Coverage     78.85%   78.85%           
=========================================
  Files           136      136           
  Lines         20849    20849           
=========================================
  Hits          16441    16441           
  Misses         4408     4408           
Flag Coverage Δ
unittests 78.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review October 8, 2024 09:10
@lewisblake lewisblake mentioned this pull request Oct 8, 2024
9 tasks
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thorbjoernl thorbjoernl merged commit efd2bcb into main-dev Oct 8, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the lewisblake-patch-1 branch October 8, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants