Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double parenthesis in read_pyaro.py L299 #1364

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Oct 7, 2024

Change Summary

Updated version of pyaro and fix double paranthesis

Related issue number

Fix #1363
Close #1368

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl
Copy link
Collaborator

thorbjoernl commented Oct 7, 2024

Tests that fail when removing brackets:

FAILED tests/io/pyaro/test_read_pyaro.py::test_pyarotoungriddeddata_reading
FAILED tests/io/pyaro/test_read_pyaro.py::test_pyarotoungriddeddata_reading_kwargs
FAILED tests/io/pyaro/test_read_pyaro.py::test_pyarotoungriddeddata_reading_extra_metadata
FAILED tests/io/pyaro/test_read_pyaro.py::test_pyarotoungriddeddata_stations
TypeError: 'method' object is not subscriptable
TypeError: object of type 'method' has no len()

I suspect pyaro is returning a method instead of calling the method somewhere which this was supposed to mask?

I think this is the source of the error: https://github.com/metno/pyaro/blob/87ac570e5f657b4df0f92017c5fac32d6c873b2d/src/pyaro/timeseries/Wrappers.py#L49

@thorbjoernl
Copy link
Collaborator

Together with metno/pyaro#44 this fixes the issue. Would this need a new pyaro release?

@lewisblake lewisblake mentioned this pull request Oct 8, 2024
9 tasks
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (ad02462) to head (1d3bb2e).
Report is 24 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1364   +/-   ##
=========================================
  Coverage     78.85%   78.85%           
=========================================
  Files           136      136           
  Lines         20781    20849   +68     
=========================================
+ Hits          16387    16441   +54     
- Misses         4394     4408   +14     
Flag Coverage Δ
unittests 78.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake added this to the m2024-10 milestone Oct 8, 2024
@lewisblake lewisblake marked this pull request as ready for review October 8, 2024 12:13
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorbjoernl thorbjoernl merged commit 7d89f8c into main-dev Oct 8, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the fix-1363 branch October 8, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double brackets being called on a dic in read_pyaro.py
2 participants