-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double parenthesis in read_pyaro.py L299 #1364
Conversation
Tests that fail when removing brackets:
I suspect pyaro is returning a method instead of calling the method somewhere which this was supposed to mask? I think this is the source of the error: https://github.com/metno/pyaro/blob/87ac570e5f657b4df0f92017c5fac32d6c873b2d/src/pyaro/timeseries/Wrappers.py#L49 |
Together with metno/pyaro#44 this fixes the issue. Would this need a new pyaro release? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1364 +/- ##
=========================================
Coverage 78.85% 78.85%
=========================================
Files 136 136
Lines 20781 20849 +68
=========================================
+ Hits 16387 16441 +54
- Misses 4394 4408 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Updated version of pyaro and fix double paranthesis
Related issue number
Fix #1363
Close #1368
Checklist