Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set equivalence checking in ModelMapsEngine #1357

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

lewisblake
Copy link
Member

Change Summary

Title. @jgriesfeller noticed this bug.

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added the bug 🐛 Something isn't working label Oct 1, 2024
@lewisblake lewisblake added this to the m2024-10 milestone Oct 1, 2024
@lewisblake lewisblake self-assigned this Oct 1, 2024
@lewisblake lewisblake marked this pull request as ready for review October 1, 2024 08:50
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.83%. Comparing base (d40203e) to head (ef31aeb).
Report is 10 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1357      +/-   ##
============================================
+ Coverage     78.68%   78.83%   +0.15%     
============================================
  Files           136      136              
  Lines         20787    20788       +1     
============================================
+ Hits          16357    16389      +32     
+ Misses         4430     4399      -31     
Flag Coverage Δ
unittests 78.83% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller merged commit c4ddcfc into main-dev Oct 1, 2024
8 checks passed
@jgriesfeller jgriesfeller deleted the fix-set-equivalence-pixel-maps branch October 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants