Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metaindx shift after metadata filter #1355

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Sep 30, 2024

Change Summary

The metadata index array was not correctly offset to match the new indices during metadata filter which caused lookup of metadata using UngriddedData.metadata to be broken after using UngriddedData.filter_by_meta()

Related issue number

closes #1354

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the bug 🐛 Something isn't working label Sep 30, 2024
@thorbjoernl thorbjoernl added this to the m2024-10 milestone Sep 30, 2024
@thorbjoernl thorbjoernl self-assigned this Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (d40203e) to head (b7ffcf9).
Report is 8 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1355   +/-   ##
=========================================
  Coverage     78.68%   78.68%           
=========================================
  Files           136      136           
  Lines         20787    20788    +1     
=========================================
+ Hits          16357    16358    +1     
  Misses         4430     4430           
Flag Coverage Δ
unittests 78.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review September 30, 2024 13:20
@thorbjoernl thorbjoernl merged commit 9abd317 into main-dev Oct 1, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the fix-metaidx-error-after-filter branch October 1, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata indecies of UngriddedData are offset relative to the metadata dictionary in some cases
2 participants