Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aerovaldb / Support put_map_overlay() in pyaerocom #1351

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Sep 26, 2024

Change Summary

Bump aerovaldb / Support put_map_overlay() in pyaerocom

Related issue number

closes #1336

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Additional Notes

Relates to metno/aerovaldb#91

@thorbjoernl thorbjoernl added the dependencies Issues related to pyaerocom dependencies label Sep 26, 2024
@thorbjoernl thorbjoernl added this to the m2024-10 milestone Sep 26, 2024
@thorbjoernl thorbjoernl self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (931e6ad) to head (1396c0a).
Report is 5 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1351   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
=========================================
  Files           136      136           
  Lines         20817    20818    +1     
=========================================
+ Hits          16440    16441    +1     
  Misses         4377     4377           
Flag Coverage Δ
unittests 78.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review September 26, 2024 08:15
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the docs. We still suspect caching issues?

@lewisblake lewisblake merged commit b1365e7 into main-dev Sep 26, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the support-map-overlay branch September 26, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues related to pyaerocom dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump aerovaldb from 0.0.17 to >=0.1.0
2 participants