Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a user specific paths.ini if it exists (in ~MyPyaerocom) #1348

Merged
merged 28 commits into from
Oct 9, 2024

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Sep 24, 2024

Change Summary

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller linked an issue Sep 24, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller self-assigned this Sep 24, 2024
@jgriesfeller jgriesfeller added this to the m2024-10 milestone Sep 24, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (114ecdd) to head (2663ca2).
Report is 49 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/config.py 89.28% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1348      +/-   ##
============================================
- Coverage     78.85%   78.49%   -0.37%     
============================================
  Files           136      136              
  Lines         20849    20846       -3     
============================================
- Hits          16441    16363      -78     
- Misses         4408     4483      +75     
Flag Coverage Δ
unittests 78.49% <89.28%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller
Copy link
Member Author

jgriesfeller commented Sep 27, 2024

Notes to myself:

  • The whole paths.ini reading and interpretation is weird and therefore needs a rewrite.
  • Why are the obs names of the legacy obs networks not read from the ini file?
  • Why are the obs names of the legacy obs networks in paths.ini?
  • Why has the BASEPATH variable in all subsections to be set (in paths.ini) and point to a valid location even when it's not used?

@jgriesfeller
Copy link
Member Author

This PR only introduces the possibility to use a user specific paths.ini in the directory ~/MyPyaerocom.
It does not address all the flaws in the current pyaerocom.const module

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, otherwise LGTM 🚀

pyaerocom/config.py Outdated Show resolved Hide resolved
pyaerocom/config.py Show resolved Hide resolved
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clean up. I agree in general we should move over to toml in the long run

pyaerocom/config.py Outdated Show resolved Hide resolved
pyaerocom/config.py Show resolved Hide resolved
pyaerocom/data/paths.ini Outdated Show resolved Hide resolved
tests/test_config.py Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
@jgriesfeller jgriesfeller marked this pull request as ready for review October 9, 2024 08:46
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewisblake lewisblake self-requested a review October 9, 2024 14:26
@lewisblake lewisblake merged commit f6148b2 into main-dev Oct 9, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the 766-make-pyaerocom-lustre-agnostic branch October 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pyaerocom lustre agnostic
3 participants