Rename setup_classes & include creation_date in ExperimentInfo

[lewisblake]

Change Summary

• Renamed setupclasses.py to setup_classes.py to follow Python module naming standard of splitting words with underscores
• Added a creation_date attribute to ExperimentInfo. Defaults to datetime.today().strftime("%Y-%m-%d") but can also be provided if a pyaeroval user wants to modified it.

Related issue number

Close https://github.com/metno/AeroToolsIssues/issues/75

Checklist

• Start with a draft-PR
• The PR title is a good summary of the changes
• PR is set to AeroTools and a tentative milestone
• Documentation reflects the changes where applicable
• Tests for the changes exist where applicable
• Tests pass locally
• Tests pass on CI
• At least 1 reviewer is selected
• Make PR ready to review

[heikoklein]

The official interface for using EvalSetup is:
from pyaerocom.aeroval import EvalSetup
Therefore, renaming setupclasses to setup_classes is fine here. It would be good if the test-cases could use the official interface rather than the internal access-path.

The documentation for EvalSetup needs to been fixed:

pyaerocom/docs/api-aeroval.rst

Line 14 in be7aeef

.. automodule:: pyaerocom.aeroval.setupclasses

Can creation_date have time-resolution e.g. https://stackoverflow.com/questions/10286204/what-is-the-right-json-date-format

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (4a7bece) to head (931e6ad).
Report is 16 commits behind head on main-dev.

Additional details and impacted files

@@            Coverage Diff            @@
##           main-dev    #1344   +/-   ##
=========================================
  Coverage     78.97%   78.97%           
=========================================
  Files           136      136           
  Lines         20815    20817    +2     
=========================================
+ Hits          16438    16440    +2     
  Misses         4377     4377           

Flag	Coverage Δ
unittests	78.97% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[heikoklein]

Please use the json-datetime format and utc.
Please use the official way to import EvalSetup where possible.

[heikoklein]

Thanks.

I just got a small idea on how to hide the setup_classes in user/test-space even more, not crucial, so I approve the PR and leave it to you if you want to change or just merge.

[heikoklein]

To avoid hardcoding class-pathes, it could be written as:

f"need instance of {EvalSetup}"

[lewisblake]

I think this ValueError.value comes from

pyaerocom/pyaerocom/_lowlevel_helpers.py

Line 105 in be7aeef

raise ValueError(f"need instance of {self._type}")

so it would be a little tricky to change just in this case.

[heikoklein]

I just meant replace

assert str(e.value) == "need instance of <class 'pyaerocom.aeroval.setupclasses.EvalSetup'>"

with

assert str(e.value) == f"need instance of {EvalSetup}"

This would not need any changes to _lowlevel_helpers.py. The string expansion of {self._type} and {class} is the the same.