Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CAMEO pyaeroval base config #1331

Closed

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Sep 2, 2024

Change Summary

The subject says it all

Related issue number

fix #1330

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller added the CAMEO Issues related to the CAMEO project label Sep 2, 2024
@jgriesfeller jgriesfeller added this to the m2024-10 milestone Sep 2, 2024
@jgriesfeller jgriesfeller self-assigned this Sep 2, 2024
@jgriesfeller jgriesfeller linked an issue Sep 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 78.61%. Comparing base (c040c77) to head (9ba3022).
Report is 18 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/config/cameo/base_config.py 0.00% 63 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1331      +/-   ##
============================================
+ Coverage     78.49%   78.61%   +0.12%     
============================================
  Files           136      137       +1     
  Lines         20845    20912      +67     
============================================
+ Hits          16362    16441      +79     
+ Misses         4483     4471      -12     
Flag Coverage Δ
unittests 78.61% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein modified the milestones: m2024-10, m2024-11 Oct 14, 2024
@jgriesfeller
Copy link
Member Author

close pull request since the original EMEP default configuration is used now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAMEO Issues related to the CAMEO project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CAMEO aeroval base configuration
2 participants