Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try new syntax to exclude mda8 from maps #1326

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Aug 27, 2024

previous fix breaks menu.json, wrong syntax

Related issue number

trying to close #1324

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@charlienegri
Copy link
Collaborator Author

I have not tested this yet

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (9e48af9) to head (a57564f).
Report is 12 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1326      +/-   ##
============================================
- Coverage     78.97%   78.96%   -0.01%     
============================================
  Files           136      136              
  Lines         20812    20813       +1     
============================================
  Hits          16436    16436              
- Misses         4376     4377       +1     
Flag Coverage Δ
unittests 78.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri
Copy link
Collaborator Author

charlienegri commented Aug 27, 2024

tested this and I do not see the variables in the map menu still even though menu.json looks correct now
https://aeroval-test.met.no/charlien/pages/maps/?project=cams2-83&experiment=test-forecast-week-2&station=ALL

this the relevant bit of menu.json

"conco3mda8": {
        "type": "3D",
        "cat": "Gas concentrations",
        "name": "O3 MDA8",
        "obs": {
            "EEA-UTD": {
                "Surface": {
                    "ENSEMBLE": {
                        "model_id": "CAMS2-83.ENSEMBLE.day0.FC",
                        "model_var": "conco3mda8",
                        "obs_var": "conco3mda8"
                    },
                    "CHIMERE": {
                        "model_id": "CAMS2-83.CHIMERE.day0.FC",
                        "model_var": "conco3mda8",
                        "obs_var": "conco3mda8"
                    },
                    ........
                    "SILAM": {
                        "model_id": "CAMS2-83.SILAM.day0.FC",
                        "model_var": "conco3mda8",
                        "obs_var": "conco3mda8"
                    }
                }
            }
        },
        "longname": "MDA8 of O3 mass concentration",
        "only_use_in": [
            "evaluation",
            "intercomp",
            "overall"
        ]
    },

@charlienegri
Copy link
Collaborator Author

charlienegri commented Aug 28, 2024

tested this and I do not see the variables in the map menu still even though menu.json looks correct now https://aeroval-test.met.no/charlien/pages/maps/?project=cams2-83&experiment=test-forecast-week-2&station=ALL

this might be due to the frontend behavior, Augustin will check

@charlienegri charlienegri added this to the m2024-09 milestone Aug 28, 2024
@charlienegri charlienegri marked this pull request as ready for review August 28, 2024 08:23
@charlienegri
Copy link
Collaborator Author

the fronted is fixed, so this syntax works and has been tested

@charlienegri charlienegri merged commit dbebc6d into main-dev Aug 28, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the exclude_conco3mda8_frommaps branch August 28, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mda8 is not computed for the maps
2 participants