-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One way to change freq for map processing #1312
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1312 +/- ##
============================================
- Coverage 78.84% 78.84% -0.01%
============================================
Files 136 136
Lines 20790 20856 +66
============================================
+ Hits 16392 16444 +52
- Misses 4398 4412 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our discussion I think we approach the other way. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only minor changes. I would opt for model_data
not modeldata
because the former is more readable and modeldata isn't an English word. I like the _get_maps_freq
function. We should use that in the overlay maps as well. If you haven't please merge with a recent version of main-dev
as well.
Agreed. I've changed the name. I have merged it in now. The overlay map now uses both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you 🥇
Change Summary
Made it so when ModelMapsEngine is run, main_freq is changed to maps_freq. If maps_freq=coarsest, then the coarsest freq of the given freqs are chosen
Related issue number
Proposed fix to #1260
Checklist