Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMEP vs. TROPOMI 2024 #1297

Merged
merged 3 commits into from
Aug 2, 2024
Merged

EMEP vs. TROPOMI 2024 #1297

merged 3 commits into from
Aug 2, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Aug 2, 2024

Change Summary

Changes to run the pyaeroval experiment of EMEP simulations vs TROPOMI NO2 observations.

Related issue number

relevant #1295

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (1a3c12e) to head (ab90b0f).
Report is 68 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1297      +/-   ##
============================================
+ Coverage     78.96%   78.99%   +0.03%     
============================================
  Files           136      136              
  Lines         20842    20794      -48     
============================================
- Hits          16458    16427      -31     
+ Misses         4384     4367      -17     
Flag Coverage Δ
unittests 78.99% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake modified the milestones: m2024-09, m2024-08 Aug 2, 2024
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewisblake lewisblake marked this pull request as ready for review August 2, 2024 09:29
@lewisblake lewisblake merged commit a686a3f into main-dev Aug 2, 2024
8 checks passed
@lewisblake lewisblake deleted the emep-tropomi-2024-2 branch August 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants