Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing definitions for conco3mda8, necessary for cams2_83 #1280

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented Jul 25, 2024

Change Summary

adding a bunch of missing definitions in order to make conco3mda8 work, as needed by cams2_83

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@charlienegri charlienegri added the CAMS2_83 Issues related to the CAMS2_83 contract label Jul 25, 2024
@charlienegri charlienegri added this to the m2024-08 milestone Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (01a158a) to head (7a538b2).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1280   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
=========================================
  Files           136      136           
  Lines         20786    20786           
=========================================
  Hits          16431    16431           
  Misses         4355     4355           
Flag Coverage Δ
unittests 79.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri charlienegri merged commit da96a58 into main-dev Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAMS2_83 Issues related to the CAMS2_83 contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants