Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emep base-config for reporting #1276

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Add emep base-config for reporting #1276

merged 7 commits into from
Jul 23, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Jul 22, 2024

Change Summary

The emep config is very long and modellers repeatedly used inconsistent versions of the base-config. Therefore, a base-config with the most common parameters is bundled with pyaerocom. The modeller only needs to adapt the base-config.

Related issue number

fixes https://github.com/metno/AeroToolsIssues/issues/2

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-08 milestone Jul 22, 2024
@heikoklein heikoklein requested a review from dulte July 22, 2024 13:58
@heikoklein heikoklein marked this pull request as ready for review July 22, 2024 14:27
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (1bf6fc2) to head (9365dc0).
Report is 50 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/aeroval/config/emep/reporting_base.py 93.65% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1276      +/-   ##
============================================
+ Coverage     78.96%   79.04%   +0.08%     
============================================
  Files           133      135       +2     
  Lines         20599    20766     +167     
============================================
+ Hits          16265    16414     +149     
- Misses         4334     4352      +18     
Flag Coverage Δ
unittests 79.04% <93.65%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up dead code. I also wonder if we should link to the documentation in the config.

pyaerocom/aeroval/config/emep/reporting_base.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/config/emep/reporting_base.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/config/emep/reporting_base.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/config/emep/reporting_base.py Outdated Show resolved Hide resolved
public=True,
# directory where colocated data files are supposed to be stored
weighted_stats=True,
var_order_menu=[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to model "good behavior" in this config by supplying the data types that EvalSetup actually expects. So for var_order_menu, this is a tuple of strings, not a list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should be able to add or remove variable in the var_order_menu before sending it to EvalSetup. This becomes unnecessarily cumbersome if it is a tuple. EvalSetup/pedantic to the cleanup/conversion to tuples.

pyaerocom/aeroval/config/emep/reporting_base.py Outdated Show resolved Hide resolved
pyaerocom/aeroval/config/emep/reporting_base.py Outdated Show resolved Hide resolved
tests/aeroval/test_aeroval_config_emep.py Outdated Show resolved Hide resolved
tests/aeroval/test_aeroval_config_emep.py Outdated Show resolved Hide resolved
tests/aeroval/test_aeroval_config_emep.py Outdated Show resolved Hide resolved
@lewisblake lewisblake merged commit 034fe3c into main-dev Jul 23, 2024
8 checks passed
@lewisblake lewisblake deleted the emep_config branch July 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants