Suppress or fix warnings #1272
Merged
Suppress or fix warnings #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1272 +/- ##
============================================
- Coverage 79.04% 78.95% -0.09%
============================================
Files 136 136
Lines 20786 20835 +49
============================================
+ Hits 16431 16451 +20
- Misses 4355 4384 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thorbjoernl
force-pushed
the
remove-warnings
branch
from
b661ab7
to
22b8697
Compare
thorbjoernl
force-pushed
the
remove-warnings
branch
from
22b8697
to
788ea9e
Compare
lewisblake
reviewed
Jul 29, 2024
| @@ -52,6 +53,10 @@ def test_unitconv_sfc_conc(dummy_data): | |||
| assert np.all(result == pytest.approx(1.99796663, 1e-4)) | |||
|
|
|||
|
|
|||
| @ignore_warnings( | |||
There was a problem hiding this comment.
Maybe add a TODO: Change to update pandas without breaking other tests
lewisblake
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR reduces the number of warnings in the log by either suppressing them, fixing the underlying issue or ignoring them depending on the warning:
stats/implementations.py, "invalid value encountered in divide" (caused by division by zero) andConstantInputWarning(correlation undefined for constant arrays) are ignored.Related issue number
#1066
Checklist