Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDA8 fix #1251

Merged
merged 7 commits into from
Jul 9, 2024
Merged

MDA8 fix #1251

merged 7 commits into from
Jul 9, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jul 9, 2024

Change Summary

Resolves a number of issues with mda8 calculation, now with an demo that works:

Related issue number

NA (See chat)

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2024-08 milestone Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.32%. Comparing base (b1fa238) to head (2dad9c7).
Report is 447 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/colocation/colocator.py 66.66% 2 Missing ⚠️
pyaerocom/aeroval/experiment_output.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1251      +/-   ##
============================================
- Coverage     79.33%   79.32%   -0.02%     
============================================
  Files           133      133              
  Lines         20289    20316      +27     
============================================
+ Hits          16096    16115      +19     
- Misses         4193     4201       +8     
Flag Coverage Δ
unittests 79.32% <78.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review July 9, 2024 08:20
@lewisblake
Copy link
Member

Notice how in the bottom left panel and in the tab at the top is says O3 although the three other panels say MDA8. We want to make sure the correct time series is being shown.
Screenshot from 2024-07-09 10-58-54

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lewisblake lewisblake merged commit 647669c into main-dev Jul 9, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the fix-mda8 branch July 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants