-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1246: var_list not being applied appropriately to obs_vars from networks #1249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1249 +/- ##
============================================
- Coverage 79.33% 79.33% -0.01%
============================================
Files 133 133
Lines 20289 20308 +19
============================================
+ Hits 16096 16111 +15
- Misses 4193 4197 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks.
After some subsequent testing I worry that this fix may have broken something with |
I had problems with |
I'm not sure why the config runs |
Yes this key error is the same one I encountered.
Not quite sure either, I'd have to debug, but I expect it's to avoid key errors when writing the json files. |
Change Summary
colocator.py::_filter_var_matches_var_names()
checks on string equality not subset inclusionpyaerocom/aeroval/experiment_processor.py
: code has been added such that if avar_list
is given, only run against the obs networks which contain that variableRelated issue number
Fix #1246
Checklist