-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify mscw-reader path requirements, read year_available from files #1245
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1245 +/- ##
============================================
- Coverage 79.33% 79.32% -0.02%
============================================
Files 133 133
Lines 20289 20301 +12
============================================
+ Hits 16096 16103 +7
- Misses 4193 4198 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Looks good otherwise
Change Summary
data-dir
to a directory containing subdirectories with four-digits. The subdirectories must contain Base_*.nc files (with * being hour, day, month, fullrun)filepath
attribute was never used and therefore removedRelated issue number
fixes #896
Checklist