Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double keys in json config file #1237

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Jul 2, 2024

Change Summary

  • EvalSetup now no longer requires exp_id and proj_id as inputs. They are now considered extra fields and just passed along to ProjectInfo and ExperimentInfo.
  • Tests which checked this functionality have been removed.

Related issue number

Closes #1173

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (48e28ea) to head (5c500ae).
Report is 474 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/setupclasses.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1237      +/-   ##
============================================
- Coverage     79.31%   79.31%   -0.01%     
============================================
  Files           131      131              
  Lines         20248    20247       -1     
============================================
- Hits          16059    16058       -1     
  Misses         4189     4189              
Flag Coverage Δ
unittests 79.31% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review July 2, 2024 11:12
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thorbjoernl thorbjoernl merged commit e6c9d66 into main-dev Jul 2, 2024
7 of 8 checks passed
@thorbjoernl thorbjoernl deleted the double-keys-in-json-config-file branch July 2, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doubled keys in json config file
2 participants