Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put all temporary and testing data below the path ~/MyPyaerocom #1230

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Jun 26, 2024

The title says it all

Change Summary

just return always a link to ~/MyPyaerocom in the Config class.
Makes all temporary pyaerocom data personal

Related issue number

fix #1229

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller self-assigned this Jun 26, 2024
@jgriesfeller jgriesfeller linked an issue Jun 26, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller added this to the m2024-07 milestone Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (e992544) to head (a95b5c2).
Report is 466 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1230      +/-   ##
============================================
- Coverage     79.31%   79.30%   -0.02%     
============================================
  Files           131      131              
  Lines         20234    20238       +4     
============================================
+ Hits          16048    16049       +1     
- Misses         4186     4189       +3     
Flag Coverage Δ
unittests 79.30% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller marked this pull request as ready for review June 26, 2024 12:01
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe mention in the release that this change has occurred, so that people are aware if their /home is too full.

@lewisblake lewisblake merged commit 2f4610a into main-dev Jun 26, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the 1229-testdata-minimal-should-be-user-specific branch June 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testdata minimal should be user-specific
2 participants