Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conversion factor for no3 to N #1214

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Jun 19, 2024

Change Summary

Conversion factor from ug N to ug for no3 is wrong (was same formula as hno3 )

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-07 milestone Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (0796175) to head (d87313a).
Report is 472 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/aux_components_fun.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1214   +/-   ##
=========================================
  Coverage     79.30%   79.31%           
=========================================
  Files           131      131           
  Lines         20234    20232    -2     
=========================================
  Hits          16047    16047           
+ Misses         4187     4185    -2     
Flag Coverage Δ
unittests 79.31% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein marked this pull request as ready for review June 19, 2024 18:43
@lewisblake lewisblake merged commit 26df81b into main-dev Jun 20, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the fix_no3_to_N_conversion branch June 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants