Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cams2-82 configs work #1209

Merged

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Jun 17, 2024

Change Summary

small change to make cams2-82 configs work

Related issue number

fix #1208

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller self-assigned this Jun 17, 2024
@jgriesfeller jgriesfeller linked an issue Jun 17, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller changed the title make cmas2-82 configs work make cams2-82 configs work Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (fb618f9) to head (0796175).
Report is 474 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/modelentry.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1209      +/-   ##
============================================
- Coverage     79.31%   79.30%   -0.01%     
============================================
  Files           131      131              
  Lines         20231    20234       +3     
============================================
+ Hits          16046    16047       +1     
- Misses         4185     4187       +2     
Flag Coverage Δ
unittests 79.30% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller marked this pull request as ready for review June 17, 2024 13:32
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lewisblake lewisblake merged commit 0bb991b into main-dev Jun 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small change to make the cams2-82 configs work
2 participants