Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy <2.0.0 #1207

Merged
merged 2 commits into from
Jun 17, 2024
Merged

numpy <2.0.0 #1207

merged 2 commits into from
Jun 17, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jun 17, 2024

Change Summary

Numpy has recently released version 2.0.0 which breaks pyaerocom (see #1206 ). This PR introduces an upper limit of numpy.

Related issue number

#1206

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2024-07 milestone Jun 17, 2024
@thorbjoernl thorbjoernl added bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies labels Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (9f4b8dc) to head (fb618f9).
Report is 486 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1207   +/-   ##
=========================================
  Coverage     79.31%   79.31%           
=========================================
  Files           131      131           
  Lines         20231    20231           
=========================================
  Hits          16046    16046           
  Misses         4185     4185           
Flag Coverage Δ
unittests 79.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review June 17, 2024 11:31
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is a temporary solution until iris releases a version which is compatible with numpy.

@lewisblake lewisblake merged commit 3976b23 into main-dev Jun 17, 2024
8 checks passed
@lewisblake lewisblake deleted the add-upper-numpy-limit branch June 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dependencies Issues related to pyaerocom dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants