Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small change to init kwargs correctly #1199

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Jun 11, 2024

Change Summary

small 2 line change to init kwargs correctly. Necessary since the parallelization calls the reading directly for caching

Related issue number

fix #1197

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (ac80b76) to head (468cce5).
Report is 511 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/pyaro/read_pyaro.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1199      +/-   ##
============================================
- Coverage     79.31%   79.31%   -0.01%     
============================================
  Files           131      131              
  Lines         20230    20231       +1     
============================================
  Hits          16046    16046              
- Misses         4184     4185       +1     
Flag Coverage Δ
unittests 79.31% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller merged commit b3a918d into main-dev Jun 14, 2024
6 of 8 checks passed
@jgriesfeller jgriesfeller deleted the 1197-pyaerocoms-pyaro-interface-might-need-small-adjustments-to-be-usable-by-the-parallelization branch June 14, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyaerocom's pyaro interface needs a small adjustment to be usable by the parallelization
2 participants