Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more with-statements where close missing #1152

Merged
merged 2 commits into from
May 3, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented May 3, 2024

Change Summary

Checking through the code fixing hanging filehandles. Most open_datasets have been fixed, either by using a with-clause, or by load_datasets. There are still some open_mfdatasets which I didn't manage to handle.

Related issue number

#1150
#1140

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@heikoklein heikoklein added this to the m2024-05 milestone May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 71.34831% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 78.69%. Comparing base (5d64e25) to head (8b17ae0).
Report is 1 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/io/read_earlinet.py 76.36% 26 Missing ⚠️
pyaerocom/colocation.py 0.00% 21 Missing ⚠️
pyaerocom/io/cachehandler_ungridded.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1152   +/-   ##
=========================================
  Coverage     78.69%   78.69%           
=========================================
  Files           127      127           
  Lines         20090    20090           
=========================================
+ Hits          15809    15810    +1     
+ Misses         4281     4280    -1     
Flag Coverage Δ
unittests 78.69% <71.34%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein marked this pull request as ready for review May 3, 2024 09:45
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@jgriesfeller jgriesfeller merged commit 2f0fafa into main-dev May 3, 2024
7 of 8 checks passed
@jgriesfeller jgriesfeller deleted the avoid_open_without_close branch May 3, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants