Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pandas #1151

Merged
merged 1 commit into from
May 3, 2024
Merged

Upgrade pandas #1151

merged 1 commit into from
May 3, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented May 3, 2024

Change Summary

Remove upper bound on pandas version.

Related issue number

fix #1141, #955

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2024-06 milestone May 3, 2024
@thorbjoernl thorbjoernl added the dependencies Issues related to pyaerocom dependencies label May 3, 2024
@thorbjoernl thorbjoernl self-assigned this May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (8b17ae0) to head (6d4aea3).
Report is 2 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1151   +/-   ##
=========================================
  Coverage     78.69%   78.69%           
=========================================
  Files           127      127           
  Lines         20090    20090           
=========================================
  Hits          15810    15810           
  Misses         4280     4280           
Flag Coverage Δ
unittests 78.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl
Copy link
Collaborator Author

  • Tests run on CI, and locally with pytest .
  • test_read_aasetal fails when running pytest through vscode.
    • May be a test ordering issue since vscode runs previously failed tests first.

@thorbjoernl
Copy link
Collaborator Author

thorbjoernl commented May 3, 2024

I think vscode was reporting tests marked as xfail as fail (test_aasetal_data, test_aasetal_data_correct_units, test_reading_routines). Not sure why it was doing that.

It is now properly reporting these tests as xfail, so there should be no issue with merging this PR.

Some of the dependencies (eg. xarray, pandas) should probably have a lower limit, but may want to wait for #1153 for that.

@thorbjoernl thorbjoernl requested a review from avaldebe May 3, 2024 11:06
@thorbjoernl thorbjoernl marked this pull request as ready for review May 3, 2024 11:07
@heikoklein heikoklein merged commit fd83ab4 into main-dev May 3, 2024
8 checks passed
@heikoklein heikoklein deleted the upgrade-pandas branch May 3, 2024 11:42
@thorbjoernl thorbjoernl removed the request for review from avaldebe May 3, 2024 11:42
@heikoklein heikoklein modified the milestones: m2024-06, m2024-05 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues related to pyaerocom dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow newer versions of pandas
2 participants