Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom variables when running aeroval #1147

Merged
merged 14 commits into from
May 28, 2024
Merged

Custom variables when running aeroval #1147

merged 14 commits into from
May 28, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented May 2, 2024

Adds possibility to add custom variables without hardcoding

Related issue number

Fix #1146

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte added the enhancement New feature or request label May 2, 2024
@dulte dulte added this to the m2024-06 milestone May 2, 2024
@dulte dulte self-assigned this May 2, 2024
@dulte dulte mentioned this pull request May 2, 2024
6 tasks
@dulte dulte requested a review from jgriesfeller May 14, 2024 09:25
@dulte dulte marked this pull request as ready for review May 14, 2024 09:25
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (63877b7) to head (0c8316f).
Report is 582 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/io/mscw_ctm/additional_variables.py 20.00% 4 Missing ⚠️
pyaerocom/io/mscw_ctm/reader.py 73.33% 4 Missing ⚠️
pyaerocom/config.py 88.88% 2 Missing ⚠️
pyaerocom/aeroval/modelentry.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1147      +/-   ##
============================================
- Coverage     79.35%   78.82%   -0.54%     
============================================
  Files           128      128              
  Lines         20162    20209      +47     
============================================
- Hits          16000    15930      -70     
- Misses         4162     4279     +117     
Flag Coverage Δ
unittests 78.82% <78.84%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the code looks quite familiar from the Readpyaro extension #1124. Anyway, let's merge this first and I will adjust #1124 accordingly. But please remove the commented out method.
Please also correct the linting.

pyaerocom/io/pyaro/read_pyaro.py Outdated Show resolved Hide resolved
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@jgriesfeller jgriesfeller merged commit b79e16d into main-dev May 28, 2024
8 checks passed
@jgriesfeller jgriesfeller deleted the custom-vars branch May 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom variables when running aeroval
2 participants