Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fairmode rounding issue #1142

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Fix fairmode rounding issue #1142

merged 3 commits into from
Apr 30, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Apr 30, 2024

Change Summary

#1117 introduced an issue where floating point arithmetic or lack of rounding resultet in R stats outside of its permissible range [1, -1] when using fairmode=True. This PR fixes this issue, by rounding the calculated values in _prepare_stats.

Related issue number

Discussion in cams2_83 chat

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (9e569d8) to head (72ec6b2).
Report is 1 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1142   +/-   ##
=========================================
  Coverage     78.59%   78.59%           
=========================================
  Files           125      125           
  Lines         19964    19964           
=========================================
  Hits          15690    15690           
  Misses         4274     4274           
Flag Coverage Δ
unittests 78.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl added this to the m2024-05 milestone Apr 30, 2024
@thorbjoernl thorbjoernl added the bug 🐛 Something isn't working label Apr 30, 2024
@thorbjoernl thorbjoernl marked this pull request as ready for review April 30, 2024 12:07
@thorbjoernl thorbjoernl merged commit a28faae into main-dev Apr 30, 2024
8 checks passed
@thorbjoernl thorbjoernl deleted the fix-fairmode-rounding branch April 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants