Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated AeronetV2 datasets #1132

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Apr 22, 2024

Change Summary

the title says it all

Related issue number

fix #1106

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller self-assigned this Apr 22, 2024
@jgriesfeller jgriesfeller linked an issue Apr 22, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller added this to the m2024-05 milestone Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (cadc4ab) to head (51541ed).
Report is 1 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1132      +/-   ##
============================================
+ Coverage     79.25%   79.27%   +0.01%     
============================================
  Files           110      110              
  Lines         19103    19095       -8     
============================================
- Hits          15140    15137       -3     
+ Misses         3963     3958       -5     
Flag Coverage Δ
unittests 79.27% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller marked this pull request as ready for review April 22, 2024 10:41
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewisblake lewisblake merged commit 09b4674 into main-dev Apr 23, 2024
8 checks passed
@lewisblake lewisblake deleted the 1106-remove-all-aeronet-v2-data-sets-paths branch April 23, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all Aeronet V2 data sets paths
2 participants