-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge CAMS2-83 code to main-dev #1128
Conversation
…s/testdata-minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work getting this PR so far. I know it's taken a lot. Feel free to take my comments in stride. This is a very large PR and introduces a lot of changes that are specific to CAMS2_83 and so generally I think an effort to delineate parts of the code that are specific to cams2-83 would benefit future programmers reading the code. The tests I understand we are not going to worry about for now, but one day I think we should revisit them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally methods in this file could benefit from more documentation in the form of docstrings
my latest commit breaks the webserver, see test-forecast-day here https://aeroval-test.met.no/charlien/pages/evaluation/?project=cams2-83&experiment=test-forecast-day&station=ALL¶meter=concpm10 |
…placement before writing the scat and map files: this means these files will contain slashes from now on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 🦄 ✨ 🚀
Change Summary
Merging cams-2-83-experiment-2 to main-dav
Related issue number
#1113
Checklist