Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_Config_read_config #1105

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix test_Config_read_config #1105

merged 1 commit into from
Apr 9, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Apr 9, 2024

Change Summary

This test was checking to see that the correct number of paths existed on lustre, but the code is not responsible for whether these paths exists - they can be deleted at anytime. A commented has been shared in the chat that those responsible for these data should submit PRs updating the paths in paths.ini

Related issue number

Close #1054

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added this to the m2024-04 milestone Apr 9, 2024
@lewisblake lewisblake marked this pull request as ready for review April 9, 2024 11:42
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (bb8c0ec) to head (dfb1fa9).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1105   +/-   ##
=========================================
  Coverage     79.22%   79.22%           
=========================================
  Files           110      110           
  Lines         19086    19087    +1     
=========================================
+ Hits          15121    15122    +1     
  Misses         3965     3965           
Flag Coverage Δ
unittests 79.22% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorbjoernl thorbjoernl merged commit f5bd073 into main-dev Apr 9, 2024
8 checks passed
@lewisblake lewisblake deleted the fix-config-tests branch July 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_config.py fail on a machine with access to /lustre/storeA and /lustre/storeB
2 participants