Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev release of Geonum instead of Github #1100

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Apr 9, 2024

Change Summary

We previously changed the Geonum to pull from Github as a fix for a broken test (#1050). There is a dev release on Pypi which incorporates the required fix (https://pypi.org/project/geonum/#history) which I think is better to use than Github.

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2024-05 milestone Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (bb8c0ec) to head (62f31bb).
Report is 3 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1100   +/-   ##
=========================================
  Coverage     79.22%   79.22%           
=========================================
  Files           110      110           
  Lines         19086    19087    +1     
=========================================
+ Hits          15121    15122    +1     
  Misses         3965     3965           
Flag Coverage Δ
unittests 79.22% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl marked this pull request as ready for review April 9, 2024 12:54
@lewisblake lewisblake merged commit 2942885 into main-dev Apr 9, 2024
8 checks passed
@lewisblake lewisblake deleted the github-to-pypi-devrelease-change branch April 9, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants