Use continue instead of pass & implement tests for vert_coords.py

[lewisblake]

Change Summary

Fixes pass instead of continue error in vert_cords.py and increases test coverage of vert_coords.py by implementing tests and removing unused code.

Related issue number

NA

Checklist

• Start with a draft-PR
• The PR title is a good summary of the changes
• PR is set to AeroTools and a tentative milestone
• Documentation reflects the changes where applicable
• Tests for the changes exist where applicable
• Tests pass locally
• Tests pass on CI
• At least 1 reviewer is selected
• Make PR ready to review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (9e569d8) to head (114bf89).
Report is 708 commits behind head on main-dev.

Additional details and impacted files

@@             Coverage Diff              @@
##           main-dev    #1049      +/-   ##
============================================
+ Coverage     78.59%   78.67%   +0.08%     
============================================
  Files           125      126       +1     
  Lines         19964    20069     +105     
============================================
+ Hits          15690    15789      +99     
- Misses         4274     4280       +6     

Flag	Coverage Δ
unittests	78.67% <100.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[avaldebe]

is this change covered by the test suite?

[lewisblake]

No, it has been specifically excluded from the testing coverage. This is probably not desired anymore.

pyaerocom/pyproject.toml

Line 136 in 7de51e0

"pyaerocom/vert_coords.py",

[lewisblake]

Will need to write tests for vert_coords.py because we using this code elsewhere now.

First step is add to test coverage.

[lewisblake]

The code coverage indicates we are not testing this module. There is no test_vert_coords either.

[thorbjoernl]

There seem to be a number of functions in vert_coords.py that aren't being used anywhere in the code base. Can these be removed? This seems to apply to:

• is_supported()
• pressure2altitude()
• geopotentialheight2altitude() (Which is also unimplemented)

[avaldebe]

good effort, please work a bit more on the tests

[thorbjoernl]

While fixing the CR issues I discovered that there were a number of references to code I had previously removed remaining in the code. These were not called in the code, and mostly used here which is an elif clause which always raises an exception, and is thus unlikely to be part of the program flow. I've cut out most of that clause, as well as any logic related to the vert_cord.py check_altitude_access() without breaking any tests.

[avaldebe]

While fixing the CR issues I discovered that there were a number of references to code I had previously removed remaining in the code. These were not called in the code, and mostly used here which is an elif clause which always raises an exception, and is thus unlikely to be part of the program flow. I've cut out most of that clause, as well as any logic related to the vert_cord.py check_altitude_access() without breaking any tests.

I do not understand what are you trying to say hare.
Where the removed, non-implemented methods, used somewhere?
Then, what did you do with the calls?
Did you removed them?

[thorbjoernl]

It is basically cleaning up left overs from my original cleanup. I had removed some functions, but missed functions which called on the removed functions. This didn't surface because that path is only in the mentioned elif clause. This just removes the remaining dangling references. So in short, yes, I removed them.

[avaldebe]

🚀 🎆

[avaldebe]

what is the purpose of this file?
are the methods here the same as the ones on vert_coords?