Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pages argument to WebDisplayOpts class #1025

Merged
merged 4 commits into from
May 28, 2024
Merged

Add pages argument to WebDisplayOpts class #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13df418
use pages in WebDisplaySetup
lewisblake Mar 7, 2024
5046e73
pages in experiment processor
lewisblake Mar 7, 2024
a8ecc1d
Merge branch 'main-dev' into pages965
lewisblake Apr 8, 2024
6189c5b
Merge branch 'main-dev' into pages965
lewisblake May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions pyaerocom/aeroval/experiment_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,7 @@
if not self.cfg.model_cfg:
logger.info("No model found, will make dummy model data")
self.cfg.webdisp_opts.hide_charts = ["scatterplot"]
self.cfg.webdisp_opts.hide_pages = [
"maps.php",
"intercomp.php",
"overall.php",
]
self.cfg.webdisp_opts.pages = ["evaluation", "infos"]

Check warning on line 126 in pyaerocom/aeroval/experiment_processor.py

View check run for this annotation

Codecov / codecov/patch

pyaerocom/aeroval/experiment_processor.py#L126 

Added line #L126 was not covered by tests
model_id = make_dummy_model(obs_list, self.cfg)
self.cfg.processing_opts.obs_only = True
use_dummy_model = True
Expand Down
2 changes: 1 addition & 1 deletion pyaerocom/aeroval/setupclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ class WebDisplaySetup(BaseModel):
hide_charts: tuple[str, ...] = ()
hide_pages: tuple[str, ...] = ()
ts_annotations: dict[str, str] = Field(default_factory=dict)
add_pages: tuple[str, ...] = ()
pages: tuple[str, ...] = ["maps", "evaluation", "intercomp", "overall", "infos"]


class EvalRunOptions(BaseModel):
Expand Down