Please consider moving the Dockerfile to the root directory #41
Comments
|
Yeah I'll do that - or if you like, you can open a PR? |
|
Sure thing! Also, sorry about saying the Dockerfile was broken, I was pulling the latest tagged release and see that you already fixed it. My bad. |
|
yep no prob! The dockerfile is referenced in the "release" workflow github action as well and needs adjustment when the file is moved |
AkbarTheGreat
added a commit
to AkbarTheGreat/matrix-alertmanager-receiver
that referenced
this issue
Sep 12, 2024
This allows shorter builds for checked out repositories (docker build .) as well as convenient builds off of the git repo (docker build <git url>). See issue metio#41 for more details.
AkbarTheGreat
added a commit
to AkbarTheGreat/matrix-alertmanager-receiver
that referenced
this issue
Sep 12, 2024
This allows shorter builds for checked out repositories (docker build .) as well as convenient builds off of the git repo (docker build <git url>). See issue metio#41 for more details.
sebhoss
pushed a commit
that referenced
this issue
Sep 12, 2024
This allows shorter builds for checked out repositories (docker build .) as well as convenient builds off of the git repo (docker build <git url>). See issue #41 for more details.
|
Fixed in #42 - thanks again! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Docker's buildkit allows clean builds of git repositories inline via something like
docker build https://github.com/metio/matrix-alertmanager-receiver.git-- but (as far as I'm aware) this only works if the Dockerfile is co-located with the root of the context. Since the Dockerfile is written assuming a context of root-of-project, it's conventional to place the file there as well.(The Dockerfile is also currently broken due to using the wrong Golang version, but that's a separate issue)
Thanks for your consideration, even if you opt not to move the file.
The text was updated successfully, but these errors were encountered: