-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented async dynamic attributes (closes #443). #460
Conversation
What's holding this PR from merging? |
@harryadel as I mentioned in the discussion above, the Promises should be catched and errors piped into the internal error handling, in order to make effective use of APM etc. |
Looks good from my end! |
Should this become a new Release for blaze? or are we waiting for other PRs to make a pr with all these changes? Like, this and #458 together ? |
I think it'd be best to release it soon, though I'm not sure what's the state of other PRs. @jankapunkt? |
this will be a minor correct? |
Yes, a minor - there's new functionality here. |
I thought we agreed to add tests in your #458? |
Yes, it's targeting this branch as merge target |
Hi guys! Is this PR going to be merged soon? Are there any blockers? |
I was certain it was already merged and released... @Grubba27, could you take a look? |
I was certain as well. Let me check that. |
Well for some reason this got lost 😢 I thought this PR and this #428 were the same. I will merge and make a new minor, v2.9(I'm not sure because this should have come with 2.8; maybe this should be a 2.8.1?) Also, is there any other PR that should come along this one @radekmie @jankapunkt ? |
No, this is a new feature - it should be 2.9.
As mentioned above, this one is first, then #458. |
I've created the #463 PR |
In this pull request, I added support for async dynamic attributes, i.e.,
<img {{getAttributesAsync}}>
. As usual, while thePromise
is still pending or rejected, an empty state is rendered, i.e., with no attributes at all.EDIT 2024-01-24: As in this discussion, I also added error handling to all async-related logic. It's based on the
Blaze._reportException
helper.